components/sync_driver/device_info_sync_service.cc - Issue 1408123003: [Sync] Initial USS service implementation for DeviceInfo.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/sync_driver/device_info_sync_service.cc

Issue 1408123003: [Sync] Initial USS service implementation for DeviceInfo. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Updated for Stan's comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/sync_driver/device_info_sync_service.h ('k') | components/sync_driver/device_info_sync_service_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/sync_driver/device_info_sync_service.cc

diff --git a/components/sync_driver/device_info_sync_service.cc b/components/sync_driver/device_info_sync_service.cc

index fb441a44bcdf8acca2613582024d7b2db0943b5f..65b9418b24112995d5df56307042a029cdf5ad16 100644

--- a/components/sync_driver/device_info_sync_service.cc

+++ b/components/sync_driver/device_info_sync_service.cc

@@ -361,7 +361,7 @@ SyncData DeviceInfoSyncService::CreateLocalData(

}

DeviceInfo* DeviceInfoSyncService::CreateDeviceInfo(

- const syncer::SyncData sync_data) {

+ const syncer::SyncData& sync_data) {

const sync_pb::DeviceInfoSpecifics& specifics =

sync_data.GetSpecifics().device_info();

« no previous file with comments | « components/sync_driver/device_info_sync_service.h ('k') | components/sync_driver/device_info_sync_service_unittest.cc » ('j') | no next file with comments »