Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1408123002: Revert of [turbofan] Initial support for monomorphic/polymorphic property loads. (Closed)

Created:
5 years, 2 months ago by Jarin
Modified:
5 years, 2 months ago
Reviewers:
Benedikt Meurer
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Initial support for monomorphic/polymorphic property loads. (patchset #3 id:100001 of https://codereview.chromium.org/1396333010/ ) Reason for revert: Waterfall redness. Original issue's description: > [turbofan] Initial support for monomorphic/polymorphic property loads. > > Native context specialization now lowers monomorphic and > polymorphic accesses to data and constant data properties on > object and/or prototype chain. We don't deal with accessors > yet, and we also completely ignore proxies (which is compatible > with what Crankshaft does). > > The code is more or less the straightforward implementation. We > will need to refactor that and extract common patterns once the > remaining bits for full load/store support is in. > > CQ_INCLUDE_TRYBOTS=tryserver.v8:v8_linux_nosnap_rel > R=jarin@chromium.org > BUG=v8:4470 > LOG=n > > Committed: https://crrev.com/3a0bf860b7177f7abef01ff308a53603389d958e > Cr-Commit-Position: refs/heads/master@{#31340} TBR=bmeurer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:4470 Committed: https://crrev.com/5c534812334fe6ab62a8e477620b1c575444b14e Cr-Commit-Position: refs/heads/master@{#31341}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -400 lines) Patch
M src/compilation-dependencies.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/compilation-dependencies.cc View 1 chunk +0 lines, -9 lines 0 comments Download
M src/compiler/js-global-specialization.h View 4 chunks +1 line, -12 lines 0 comments Download
M src/compiler/js-global-specialization.cc View 5 chunks +6 lines, -365 lines 0 comments Download
M src/compiler/js-graph.cc View 2 chunks +3 lines, -6 lines 0 comments Download
M src/compiler/js-inlining.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/compiler/pipeline.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/field-index.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/objects.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/objects-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/es6/block-scoping.js View 1 chunk +1 line, -0 lines 0 comments Download
M test/mjsunit/harmony/block-scoping-sloppy.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Jarin
Created Revert of [turbofan] Initial support for monomorphic/polymorphic property loads.
5 years, 2 months ago (2015-10-16 14:55:44 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408123002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408123002/1
5 years, 2 months ago (2015-10-16 14:55:53 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-16 14:56:11 UTC) #3
commit-bot: I haz the power
5 years, 2 months ago (2015-10-16 14:56:34 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5c534812334fe6ab62a8e477620b1c575444b14e
Cr-Commit-Position: refs/heads/master@{#31341}

Powered by Google App Engine
This is Rietveld 408576698