Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Unified Diff: master/master_private_builders_cfg.py

Issue 14081044: Add Validation for BuildFactory Configuration (Closed) Base URL: http://skia.googlecode.com/svn/buildbot/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: master/master_private_builders_cfg.py
===================================================================
--- master/master_private_builders_cfg.py (revision 8776)
+++ master/master_private_builders_cfg.py (working copy)
@@ -5,8 +5,9 @@
# Sets up all the builders we want this buildbot master to run.
from skia_master_scripts import utils
+from skia_master_scripts import android_factory
from skia_master_scripts import factory as skia_factory
-from skia_master_scripts.utils import MakeAndroidBuilderSet
+
# Directory where we want to record performance data
#
# TODO(epoger): consider changing to reuse existing config.Master.perf_base_url,
@@ -40,8 +41,9 @@
#
########## LIST ALL PRIVATELY VISIBLE BUILDERS HERE ##########
- MakeAndroidBuilderSet(
+ utils.MakeBuilderSet(
helper=helper,
+ factory_type=android_factory.AndroidFactory,
scheduler='skia_rel',
builder_base_name='Skia_Private_Builder_%s_001',
device='nexus_s',
@@ -50,8 +52,9 @@
environment_variables={'GYP_DEFINES': 'skia_scalar=float'},
gm_image_subdir=None,
perf_output_basedir=perf_output_basedir_linux)
- MakeAndroidBuilderSet(
+ utils.MakeBuilderSet(
helper=helper,
+ factory_type=android_factory.AndroidFactory,
scheduler='skia_rel',
builder_base_name='Skia_Private_Builder_%s_002',
device='nexus_s',
@@ -60,8 +63,9 @@
environment_variables={'GYP_DEFINES': 'skia_scalar=float'},
gm_image_subdir=None,
perf_output_basedir=perf_output_basedir_linux)
- MakeAndroidBuilderSet(
+ utils.MakeBuilderSet(
helper=helper,
+ factory_type=android_factory.AndroidFactory,
scheduler='skia_rel',
builder_base_name='Skia_Private_Builder_%s_003',
device='nexus_s',

Powered by Google App Engine
This is Rietveld 408576698