Add Validation for BuildFactory Configuration

master/skia_master_scripts/utils.py

 # Copyright (c) 2013 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 
 """Miscellaneous utilities needed by the Skia buildbot master."""
 
 
 import httplib2
 import re
@@ skipping 27 matching lines @@
 TRYBOT_NAME_SUFFIX = '_Trybot'
 TRY_SCHEDULER_SVN = 'skia_try_svn'
 TRY_SCHEDULER_RIETVELD = 'skia_try_rietveld'
 TRY_SCHEDULERS = [TRY_SCHEDULER_SVN, TRY_SCHEDULER_RIETVELD]
 TRY_SCHEDULERS_STR = '|'.join(TRY_SCHEDULERS)
 
 
 def IsTrybot(builder_name):
   return builder_name.endswith(TRYBOT_NAME_SUFFIX)
 
 

[borenet, 2013/04/25 15:50:28]

Helpers for dumping out the dictionary.  We need this because the default
tostring functions don't handle objects well - they print out the memory
location which is incompatible with our use case.  This is also more nicely
formatted.

+def IndentStr(indent):

[rmistry, 2013/04/25 17:31:50]

private function?
The only one that looks useful here for external callers is ToString

[borenet, 2013/04/25 18:28:09]

Done.

+  string = ''
+  for _ in range(indent + 1):
+    string += '    '
+  return string
+
+
+def ToString(o, indent=0):

[rmistry, 2013/04/25 17:31:50]

If this is going to be the only public function lets add detailed pydoc about
what it is doing.

[borenet, 2013/04/25 18:28:09]

Done.

+  if isinstance(o, list):
+    return ListToString(o, indent)
+  elif isinstance(o, dict):
+    return DictToString(o, indent)
+  elif isinstance(o, tuple):
+    return ListToString(o, indent)
+  elif isinstance(o, str):
+    return '\'%s\'' % o
+  elif o is None:
+    return 'None'
+  else:
+    return '<Object>'
+
+
+def ListToString(l, indent):

[rmistry, 2013/04/25 17:31:50]

private function?

[borenet, 2013/04/25 18:28:09]

Done.

+  if not l:
+    return '[]'
+  indent_str = IndentStr(indent)
+  val = '[\n'
+  indent += 1
+  val += ''.join(['%s%s,\n' % (indent_str, ToString(elem, indent)) \
+                  for elem in l])
+  indent -= 1
+  indent_str = IndentStr(indent - 1)
+  val += indent_str + ']'
+  return val
+
+
+def DictToString(d, indent):

[rmistry, 2013/04/25 17:31:50]

private function?

[borenet, 2013/04/25 18:28:09]

Done.

+  if not d:
+    return '{}'
+  indent_str = IndentStr(indent)
+  val = '{\n'
+  indent += 1
+  val += ''.join(['%s%s: %s,\n' % (indent_str, ToString(k, indent),
+                                   ToString(d[k], indent)) \
+                  for k in sorted(d.keys())])
+  indent -= 1
+  indent_str = IndentStr(indent - 1)
+  val += indent_str + '}'
+  return val
+
+
 class SkiaChangeFilter(ChangeFilter):
   """Skia specific subclass of ChangeFilter."""
 
   def __init__(self, builders, **kwargs):
     self._builders = builders
     ChangeFilter.__init__(self, **kwargs)
 
   def filter_change(self, change):
     """Overrides ChangeFilter.filter_change to pass builders to filter_fn.
 
@@ skipping 555 matching lines @@
   # request is associated with a change but the revisions match (#5 above).
   if req1.source.changes and not req2.source.changes:
     return False
   if not req1.source.changes and req2.source.changes:
     return False
   if not (req1.source.changes and req2.source.changes):
     if req1.source.revision != req2.source.revision:
       return False
   
   return True