Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3705)

Unified Diff: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc

Issue 14081043: Hook up Autofill Backend interface to SyncableServices (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Update interface Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
diff --git a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
index 316829a03fec2e9113e4f50ca485cf238edad845..b2e0f1b50f264fd2074097ceffabe610d1dda74a 100644
--- a/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
+++ b/chrome/browser/sync/glue/autofill_data_type_controller_unittest.cc
@@ -31,6 +31,7 @@
#include "testing/gtest/include/gtest/gtest.h"
using autofill::AutofillWebDataService;
+using autofill::AutofillWebDataBackend;
namespace browser_sync {
@@ -41,6 +42,19 @@ using testing::_;
using testing::NiceMock;
using testing::Return;
+class NoOpAutofillBackend : public AutofillWebDataBackend {
+ public:
+ NoOpAutofillBackend() {}
+ virtual ~NoOpAutofillBackend() {}
+ virtual WebDatabase* GetDatabase() OVERRIDE { return NULL; }
+ virtual void AddObserver(
+ autofill::AutofillWebDataServiceObserverOnDBThread* observer) OVERRIDE {}
+ virtual void RemoveObserver(
+ autofill::AutofillWebDataServiceObserverOnDBThread* observer) OVERRIDE {}
+ virtual void RemoveExpiredFormElementsWrapper() OVERRIDE {}
+ virtual void NotifyOfMultipleAutofillChanges() OVERRIDE {}
+};
+
// Fake WebDataService implementation that stubs out the database loading.
class FakeWebDataService : public AutofillWebDataService {
public:
@@ -120,11 +134,14 @@ class FakeWebDataService : public AutofillWebDataService {
void CreateSyncableService() {
ASSERT_TRUE(BrowserThread::CurrentlyOn(BrowserThread::DB));
// These services are deleted in DestroySyncableService().
- AutocompleteSyncableService::CreateForWebDataService(this);
+ autofill_backend_.reset(new NoOpAutofillBackend());
+ AutocompleteSyncableService::CreateForWebDataService(
+ this,
+ autofill_backend_.get());
}
bool is_database_loaded_;
-
+ scoped_ptr<AutofillWebDataBackend> autofill_backend_;
Ilya Sherman 2013/05/13 23:44:47 nit: Can this be a direct class member rather than
Cait (Slow) 2013/05/14 22:30:08 Done.
WebDatabaseObserver* observer_;
DISALLOW_COPY_AND_ASSIGN(FakeWebDataService);

Powered by Google App Engine
This is Rietveld 408576698