Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 14081031: Revert 195845 "With this CL we can catch OnResume, OnPause, OnDe..." (Closed)

Created:
7 years, 8 months ago by gavinp
Modified:
7 years, 8 months ago
Reviewers:
felipeg
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 195845 "With this CL we can catch OnResume, OnPause, OnDe..." > With this CL we can catch OnResume, OnPause, OnDestroy and OnStop notifications in SimpleCache, so we save our index before we get killed. > > OnPause means the app lost focus (went to the background). > > The idea is that we can write the index file to disk on every OnPause, and while the app is in the background we can aggressively increase the frequency we write the index file to disk. > > BUG=233536 > > Review URL: https://chromiumcodereview.appspot.com/14362009 BUG=235180 TBR=felipeg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=196357

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -241 lines) Patch
D trunk/src/net/android/java/src/org/chromium/net/SimpleCacheActivityStatusNotifier.java View 1 chunk +0 lines, -72 lines 0 comments Download
M trunk/src/net/android/net_jni_registrar.cc View 2 chunks +1 line, -4 lines 0 comments Download
D trunk/src/net/android/simple_cache_activity_status_notifier.h View 1 chunk +0 lines, -62 lines 0 comments Download
D trunk/src/net/android/simple_cache_activity_status_notifier.cc View 1 chunk +0 lines, -54 lines 0 comments Download
M trunk/src/net/disk_cache/simple/simple_index.h View 3 chunks +4 lines, -14 lines 0 comments Download
M trunk/src/net/disk_cache/simple/simple_index.cc View 8 chunks +19 lines, -32 lines 0 comments Download
M trunk/src/net/net.gyp View 2 chunks +0 lines, -3 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
gavinp
7 years, 8 months ago (2013-04-25 08:22:01 UTC) #1
gavinp
7 years, 8 months ago (2013-04-25 08:24:19 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r196357.

Powered by Google App Engine
This is Rietveld 408576698