Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(224)

Unified Diff: chrome/browser/extensions/api/identity/experimental_identity_api.h

Issue 14081014: Identity API: Change WebAuthFlow to use <webview> instead of a normal browser pop-up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: chrome.identity side-by-side with chrome.experimental.identity Created 7 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/identity/experimental_identity_api.h
diff --git a/chrome/browser/extensions/api/identity/experimental_identity_api.h b/chrome/browser/extensions/api/identity/experimental_identity_api.h
index c0889f68671b7b1a7c9d4f90b6f96d80ae08ea1d..cf165dc3e0426db9104fe489b5b7ce2a5d8db503 100644
--- a/chrome/browser/extensions/api/identity/experimental_identity_api.h
+++ b/chrome/browser/extensions/api/identity/experimental_identity_api.h
@@ -10,9 +10,9 @@
#include "base/memory/ref_counted.h"
#include "base/memory/weak_ptr.h"
+#include "chrome/browser/extensions/api/identity/experimental_web_auth_flow.h"
#include "chrome/browser/extensions/api/identity/identity_mint_queue.h"
#include "chrome/browser/extensions/api/identity/identity_signin_flow.h"
-#include "chrome/browser/extensions/api/identity/web_auth_flow.h"
#include "chrome/browser/extensions/extension_function.h"
#include "chrome/browser/extensions/extension_install_prompt.h"
#include "google_apis/gaia/oauth2_mint_token_flow.h"
@@ -110,7 +110,7 @@ class ExperimentalIdentityGetAuthTokenFunction
class ExperimentalIdentityLaunchWebAuthFlowFunction
: public AsyncExtensionFunction,
- public WebAuthFlow::Delegate {
+ public ExperimentalWebAuthFlow::Delegate {
public:
DECLARE_EXTENSION_FUNCTION("experimental.identity.launchWebAuthFlow",
EXPERIMENTAL_IDENTITY_LAUNCHWEBAUTHFLOW);
@@ -130,12 +130,13 @@ class ExperimentalIdentityLaunchWebAuthFlowFunction
// Helper to initialize final URLs vector.
void InitFinalRedirectURLPrefixes(const std::string& extension_id);
- scoped_ptr<WebAuthFlow> auth_flow_;
+ scoped_ptr<ExperimentalWebAuthFlow> auth_flow_;
std::vector<GURL> final_prefixes_;
private:
- // WebAuthFlow::Delegate implementation.
- virtual void OnAuthFlowFailure(WebAuthFlow::Failure failure) OVERRIDE;
+ // ExperimentalWebAuthFlow::Delegate implementation.
+ virtual void OnAuthFlowFailure(ExperimentalWebAuthFlow::Failure failure)
+ OVERRIDE;
virtual void OnAuthFlowURLChange(const GURL& redirect_url) OVERRIDE;
};
« no previous file with comments | « chrome/browser/browser_resources.grd ('k') | chrome/browser/extensions/api/identity/experimental_identity_api.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698