Fix memory leaks in tests caused by not tearing down TemplateUrlService correctly.

Fix memory leaks in tests caused by not tearing down TemplateUrlService correctly.

These were introduced in https://codereview.chromium.org/13932025/.

R=pkasting@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194498

[Cait (Slow), 2013-04-16 19:18:04]

PTAL. This fixes mem-leaks caused by not calling the newly added Shutdown()
method on TemplateURLService during unit tests.

[Peter Kasting, 2013-04-16 19:38:50]

This feels fragile.  Should we do something like call Shutdown() from the
destructor (and NULL out anything additional necessary there to prevent any
double-shutdown sorts of effects) to ensure that callers don't need to do this
manually?

If that's a bad idea for some reason, then LGTM.

[Cait (Slow), 2013-04-16 19:57:13]

On 2013/04/16 19:38:50, Peter Kasting wrote:
> This feels fragile.  Should we do something like call Shutdown() from the
> destructor (and NULL out anything additional necessary there to prevent any
> double-shutdown sorts of effects) to ensure that callers don't need to do this
> manually?
> 
> If that's a bad idea for some reason, then LGTM.

Most of the time, TemplateURLService is being managed by the
ProfileDependencyManager, so we can be pretty certain that Shutdown() will get
called, but I agree that for unit tests, this approach is fragile. Patchset 2
uses the approach you suggested, and should be less fragile.

[Peter Kasting, 2013-04-16 20:03:35]

LGTM

[Cait (Slow), 2013-04-17 00:26:13]

Committed patchset #2 manually as r194498 (presubmit successful).