Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1477)

Unified Diff: third_party/WebKit/Source/web/WebFrame.cpp

Issue 1408073006: Gracefully handle a self-referential opener in frame swap. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add comment Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/WebFrame.cpp
diff --git a/third_party/WebKit/Source/web/WebFrame.cpp b/third_party/WebKit/Source/web/WebFrame.cpp
index a1f3cd60efa89ff2014de9e3dc694cbe09fd68de..5e979c40ed4872e19c0d7a41a73e207ada4aca20 100644
--- a/third_party/WebKit/Source/web/WebFrame.cpp
+++ b/third_party/WebKit/Source/web/WebFrame.cpp
@@ -74,14 +74,10 @@ bool WebFrame::swap(WebFrame* frame)
}
if (m_opener) {
- m_opener->m_openedFrameTracker->remove(this);
- m_opener->m_openedFrameTracker->add(frame);
- swap(m_opener, frame->m_opener);
- }
- if (!m_openedFrameTracker->isEmpty()) {
- m_openedFrameTracker->updateOpener(frame);
- frame->m_openedFrameTracker.reset(m_openedFrameTracker.release());
+ frame->setOpener(m_opener);
+ setOpener(nullptr);
}
+ m_openedFrameTracker->transferTo(frame);
FrameHost* host = oldFrame->host();
AtomicString name = oldFrame->tree().name();
« no previous file with comments | « third_party/WebKit/Source/web/OpenedFrameTracker.cpp ('k') | third_party/WebKit/Source/web/tests/WebFrameTest.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698