Issue 1408073005: win: Fix x64 compile error in handle writer

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408073005: win: Fix x64 compile error in handle writer (Closed)

Created:
5 years, 2 months ago by scottmg

Modified:
5 years, 2 months ago

Reviewers:
Mark Mentovai

CC:
crashpad-dev_chromium.org

Base URL:
https://chromium.googlesource.com/crashpad/crashpad@master

Target Ref:
refs/heads/master

Project:
crashpad

Visibility:
Public.

More Reviews

Description

win: Fix x64 compile error in handle writer R=mark@chromium.org BUG=crashpad:52 Committed: https://chromium.googlesource.com/crashpad/crashpad/+/38b7e919f87cc4537be1ac451af1fb130fe0e4f1

Patch Set 2 : . #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -1 line)			Patch
	M	minidump/minidump_handle_writer.cc	View	1	2 chunks	+7 lines, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

LGTM https://codereview.chromium.org/1408073005/diff/1/minidump/minidump_handle_writer.cc File minidump/minidump_handle_writer.cc (right): https://codereview.chromium.org/1408073005/diff/1/minidump/minidump_handle_writer.cc#newcode82 minidump/minidump_handle_writer.cc:82: handle_count)) { You didn’t need handle_count, but if ...

5 years, 2 months ago (2015-10-21 22:19:26 UTC) #2

scottmg

https://codereview.chromium.org/1408073005/diff/1/minidump/minidump_handle_writer.cc File minidump/minidump_handle_writer.cc (right): https://codereview.chromium.org/1408073005/diff/1/minidump/minidump_handle_writer.cc#newcode82 minidump/minidump_handle_writer.cc:82: handle_count)) { On 2015/10/21 22:19:26, Mark Mentovai wrote: > ...

5 years, 2 months ago (2015-10-21 22:35:53 UTC) #3

scottmg

5 years, 2 months ago (2015-10-21 22:36:04 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
38b7e919f87cc4537be1ac451af1fb130fe0e4f1 (presubmit successful).

Expand Messages | Collapse Messages

Issue 1408073005: win: Fix x64 compile error in handle writer (Closed)

Description

Patch Set 1 #

Patch Set 2 : . #

Messages