core/include/fpdfapi/fpdf_resource.h - Issue 1408063016: Fix a leak in CPDF_Type3Font::LoadChar().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/include/fpdfapi/fpdf_resource.h

Issue 1408063016: Fix a leak in CPDF_Type3Font::LoadChar(). (Closed) Base URL: https://pdfium.googlesource.com/pdfium@parser_b268

Patch Set: Created 5 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/include/fpdfapi/fpdf_resource.h

diff --git a/core/include/fpdfapi/fpdf_resource.h b/core/include/fpdfapi/fpdf_resource.h

index dee15cf941eb65bd0a894e270982930aea98db5a..d6249102b6f5e8a6e7f8c20dbd747e7ab381a6ce 100644

--- a/core/include/fpdfapi/fpdf_resource.h

+++ b/core/include/fpdfapi/fpdf_resource.h

@@ -7,6 +7,8 @@

#ifndef CORE_INCLUDE_FPDFAPI_FPDF_RESOURCE_H_

#define CORE_INCLUDE_FPDFAPI_FPDF_RESOURCE_H_

+#include <map>

#include "../fxcrt/fx_system.h"

#include "../fxge/fx_font.h"

#include "fpdf_parser.h"

@@ -410,8 +412,7 @@ class CPDF_Type3Font : public CPDF_SimpleFont {

CPDF_Dictionary* m_pCharProcs;

CPDF_Dictionary* m_pPageResources;

CPDF_Dictionary* m_pFontResources;

- CFX_MapPtrToPtr m_CacheMap;

- CFX_MapPtrToPtr m_DeletedMap;

+ std::map<FX_DWORD, CPDF_Type3Char*> m_CacheMap;

};

enum CIDSet {