Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(287)

Issue 1408063013: Revert of [es6] Implement destructuring binding in try/catch (Closed)

Created:
5 years, 1 month ago by adamk
Modified:
5 years, 1 month ago
Reviewers:
rossberg
CC:
v8-reviews_googlegroups.com, caitp (gmail)
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [es6] Implement destructuring binding in try/catch (patchset #3 id:40001 of https://codereview.chromium.org/1417483014/ ) Reason for revert: MSAN errors on arm64: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20MSAN/builds/5123/ Original issue's description: > [es6] Implement destructuring binding in try/catch > > The approach is to desugar > > try { ... } > catch ({x, y}) { ... } > > into > > try { ... } > catch (.catch) { > let x = .catch.x; > let y = .catch.y; > ... > } > > using the PatternRewriter's normal facilities. This has the side benefit > of throwing the appropriate variable conflict errors for declarations > made inside the catch block. > > No change is made to non-destructured cases, which will hopefully save > us some work if https://github.com/tc39/ecma262/issues/150 is adopted > in the spec. > > There's one big problem with this patch, which is a lack of PreParser > support for the redeclaration errors. But it seems we're already lacking > good PreParser support for such errors, so I'm not sure that should > block this moving forward. > > BUG=v8:811 > LOG=y > > Committed: https://crrev.com/a316db995e6e4253664920652ed4e5a38b2caeba > Cr-Commit-Position: refs/heads/master@{#31797} TBR=rossberg@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=v8:811 Committed: https://crrev.com/f687c4f4e69afd456ddcf654daf62ae00bb18641 Cr-Commit-Position: refs/heads/master@{#31798}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -130 lines) Patch
M src/ast-value-factory.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/parser.cc View 3 chunks +8 lines, -67 lines 0 comments Download
M src/preparser.cc View 1 chunk +1 line, -4 lines 0 comments Download
M test/cctest/test-parsing.cc View 2 chunks +0 lines, -2 lines 0 comments Download
D test/message/try-catch-lexical-conflict.js View 1 chunk +0 lines, -11 lines 0 comments Download
D test/message/try-catch-lexical-conflict.out View 1 chunk +0 lines, -4 lines 0 comments Download
D test/message/try-catch-variable-conflict.js View 1 chunk +0 lines, -10 lines 0 comments Download
D test/message/try-catch-variable-conflict.out View 1 chunk +0 lines, -4 lines 0 comments Download
M test/mjsunit/harmony/destructuring.js View 1 chunk +0 lines, -27 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
adamk
Created Revert of [es6] Implement destructuring binding in try/catch
5 years, 1 month ago (2015-11-04 16:39:23 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408063013/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408063013/1
5 years, 1 month ago (2015-11-04 16:39:27 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-04 16:39:42 UTC) #3
commit-bot: I haz the power
5 years, 1 month ago (2015-11-04 16:40:09 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f687c4f4e69afd456ddcf654daf62ae00bb18641
Cr-Commit-Position: refs/heads/master@{#31798}

Powered by Google App Engine
This is Rietveld 408576698