Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1408063008: [Telemetry] Make the logging message when screenshot capturing fail less verbose. (Closed)

Created:
5 years, 1 month ago by nednguyen
Modified:
5 years, 1 month ago
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Telemetry] Make the logging message when screenshot capturing fail less verbose. Adding the stack trace of screenshot failure will make it's harder for perf sherrifs to diagnore issue. Switch this to log the exception object instead. BUG=549326 Committed: https://crrev.com/2fa40f2cb37ef537d174e3852356ee8c257b7edf Cr-Commit-Position: refs/heads/master@{#357012}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/telemetry/telemetry/page/shared_page_state.py View 1 chunk +3 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
nednguyen
5 years, 1 month ago (2015-10-29 22:42:11 UTC) #2
aiolos (Not reviewing)
lgtm
5 years, 1 month ago (2015-10-29 23:51:50 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408063008/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408063008/1
5 years, 1 month ago (2015-10-29 23:58:44 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-10-30 01:27:17 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-30 01:28:54 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2fa40f2cb37ef537d174e3852356ee8c257b7edf
Cr-Commit-Position: refs/heads/master@{#357012}

Powered by Google App Engine
This is Rietveld 408576698