third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h - Issue 1408063004: Parse animation and transition shorthands in CSSPropertyParser with CSSParserTokens

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

Issue 1408063004: Parse animation and transition shorthands in CSSPropertyParser with CSSParserTokens (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@anim4

Patch Set: address comments Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/animations/animations-parsing-expected.txt ('k') | third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

diff --git a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

index a33384f8db63ae7271d90bdbce3fac0fef3b26df..1bdbaf82034819a4cc4e5da5794055bbcef9510a 100644

--- a/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

+++ b/third_party/WebKit/Source/core/css/parser/CSSPropertyParser.h

@@ -140,23 +140,10 @@ private:

void addFillValue(RefPtrWillBeRawPtr<CSSValue>& lval, PassRefPtrWillBeRawPtr<CSSValue> rval);

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationDelay();

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationDirection();

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationDuration();

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationFillMode();

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationIterationCount();

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationName(bool allowQuotedName);

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationPlayState();

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationProperty();

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationTimingFunction();

bool parseCubicBezierTimingFunctionValue(CSSParserValueList*& args, double& result);

// Legacy parsing allows <string>s for animation-name

- PassRefPtrWillBeRawPtr<CSSValue> parseAnimationProperty(CSSPropertyID, bool useLegacyParsing);

- PassRefPtrWillBeRawPtr<CSSValueList> parseAnimationPropertyList(CSSPropertyID, bool useLegacyParsing);

- bool parseAnimationShorthand(bool useLegacyParsing, bool important);

- bool parseTransitionShorthand(bool important);

+ bool consumeAnimationShorthand(const StylePropertyShorthand&, bool useLegacyParsing, bool important);

bool consumeColumns(bool important);