pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart - Issue 1408043002: Move native and js interop properties from the element model to the JS backend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

Issue 1408043002: Move native and js interop properties from the element model to the JS backend (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_emitter/program_builder/collector.dart ('k') | pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

diff --git a/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart b/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

index 0388bc9c356f5283842f0b52a4a300b5a3559a9b..40bebf30b2de5364df3ddd73abef4ffeb90171bd 100644

--- a/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

+++ b/pkg/compiler/lib/src/js_emitter/program_builder/field_visitor.dart

@@ -80,7 +80,7 @@ class FieldVisitor {

// Keep track of whether or not we're dealing with a field mixin

// into a native class.

bool isMixinNativeField =

- isClass && element.isNative && holder.isMixinApplication;

+ isClass && backend.isNative(element) && holder.isMixinApplication;

// See if we can dynamically create getters and setters.

// We can only generate getters and setters for [element] since

@@ -93,7 +93,7 @@ class FieldVisitor {

needsSetter = fieldNeedsSetter(field);

}

- if ((isInstantiated && !holder.isNative)

+ if ((isInstantiated && !backend.isNative(holder))

|| needsGetter

|| needsSetter) {

js.Name accessorName = namer.fieldAccessorName(field);