pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart - Issue 1408043002: Move native and js interop properties from the element model to the JS backend

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

Issue 1408043002: Move native and js interop properties from the element model to the JS backend (Closed) Base URL: https://github.com/dart-lang/sdk.git@master

Patch Set: Updated cf. comments. Created 5 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « pkg/compiler/lib/src/js_backend/patch_resolver.dart ('k') | pkg/compiler/lib/src/js_emitter/interceptor_stub_generator.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

diff --git a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

index 473766ab694b9bb4a45a2710ec63fd39b19198de..07eb81ce5949ada8f4c3d28e6d2485530dcead39 100644

--- a/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

+++ b/pkg/compiler/lib/src/js_emitter/full_emitter/emitter.dart

@@ -1833,14 +1833,16 @@ function(originalDescriptor, name, holder, isStatic, globalFunctionsAccess) {

ClassBuilder getElementDescriptor(Element element, Fragment fragment) {

Element owner = element.library;

- if (!element.isLibrary && !element.isTopLevel && !element.isNative) {

+ if (!element.isLibrary &&

+ !element.isTopLevel &&

+ !backend.isNative(element)) {

// For static (not top level) elements, record their code in a buffer

// specific to the class. For now, not supported for native classes and

// native elements.

ClassElement cls =

element.enclosingClassOrCompilationUnit.declaration;

if (compiler.codegenWorld.directlyInstantiatedClasses.contains(cls) &&

- !cls.isNative &&

+ !backend.isNative(cls) &&

compiler.deferredLoadTask.outputUnitForElement(element) ==

compiler.deferredLoadTask.outputUnitForElement(cls)) {

owner = cls;