Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(362)

Issue 1408033011: [PI] Quick fix for FunctionHandle loading strategy (Closed)

Created:
5 years, 1 month ago by eakuefner
Modified:
5 years, 1 month ago
Reviewers:
beaudoin
CC:
catapult-reviews_chromium.org, tracing-review_chromium.org
Base URL:
git@github.com:catapult-project/catapult.git@master
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

[PI] Quick fix for FunctionHandle loading strategy There is a field in function handle dicts called 'function_name' that was being referred to in the JS as 'functionName'. This fixes the JS to match the former. BUG=catapult:#1703 Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/f740b6218c16815bbf65f12ef0cc7ebc294462b5

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M perf_insights/perf_insights/function_handle.html View 1 chunk +1 line, -1 line 0 comments Download
M perf_insights/perf_insights/function_handle_test.html View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
eakuefner
PTAL
5 years, 1 month ago (2015-11-07 01:33:40 UTC) #3
beaudoin
LGTM
5 years, 1 month ago (2015-11-07 01:38:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408033011/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408033011/1
5 years, 1 month ago (2015-11-07 01:38:23 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-11-07 01:45:21 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698