Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Issue 1408033003: MIPS: [turbofan] Optimize fpu compares with zero literal. (Closed)

Created:
5 years, 2 months ago by dusan.milosavljevic
Modified:
5 years, 2 months ago
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

MIPS: [turbofan] Optimize fpu compares with zero literal. TEST= BUG= Committed: https://crrev.com/e40b1b42307c58ba6d5b00f04be360748467b8cf Cr-Commit-Position: refs/heads/master@{#31426}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -28 lines) Patch
M src/compiler/mips/code-generator-mips.cc View 3 chunks +32 lines, -6 lines 0 comments Download
M src/compiler/mips/instruction-selector-mips.cc View 2 chunks +16 lines, -8 lines 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 3 chunks +32 lines, -6 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 2 chunks +16 lines, -8 lines 0 comments Download
M src/mips/macro-assembler-mips.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/mips64/macro-assembler-mips64.h View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dusan.milosavljevic
PTAL.
5 years, 2 months ago (2015-10-16 11:13:32 UTC) #2
titzer
This lgtm for now, but this problem needs to be fixed at a deeper level; ...
5 years, 2 months ago (2015-10-16 17:08:12 UTC) #3
paul.l...
LGTM.
5 years, 2 months ago (2015-10-19 18:37:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408033003/1
5 years, 2 months ago (2015-10-20 10:58:28 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: v8_mac_rel on tryserver.v8 (JOB_TIMED_OUT, http://build.chromium.org/p/tryserver.v8/builders/v8_mac_rel/builds/10881)
5 years, 2 months ago (2015-10-20 16:58:50 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408033003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408033003/1
5 years, 2 months ago (2015-10-20 21:42:48 UTC) #10
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 21:53:53 UTC) #11
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 21:54:11 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e40b1b42307c58ba6d5b00f04be360748467b8cf
Cr-Commit-Position: refs/heads/master@{#31426}

Powered by Google App Engine
This is Rietveld 408576698