Issue 140803003: Move the Autofill and URLBlacklist policy handlers to the component.

Issue 140803003: Move the Autofill and URLBlacklist policy handlers to the component. (Closed)

Created:
6 years, 11 months ago by Joao da Silva

Modified:
6 years, 11 months ago

Reviewers:
jochen (gone - plz use gerrit), dconnelly

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Move the Autofill and URLBlacklist policy handlers to the component. All the dependencies of these policy handlers have already been moved into the policy component, and they can now be moved as well. This enables their usage on ios builds. BUG=275292 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245522

Patch Set 1 #

Patch Set 2 : fix dependency of policy_component_browser on policy #

Patch Set 3 : link with autofill_core_browser #

Patch Set 4 : .... #

Patch Set 5 : trying again... #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+34 lines, -278 lines)			Patch
D	chrome/browser/policy/autofill_policy_handler.h	View	4	1 chunk	+0 lines, -32 lines	0 comments	Download
D	chrome/browser/policy/autofill_policy_handler.cc	View	4	1 chunk	+0 lines, -32 lines	0 comments	Download
D	chrome/browser/policy/autofill_policy_handler_unittest.cc	View	4	1 chunk	+0 lines, -62 lines	0 comments	Download
M	chrome/browser/policy/configuration_policy_handler_list_factory.cc	View	4	1 chunk	+2 lines, -2 lines	0 comments	Download
D	chrome/browser/policy/url_blacklist_policy_handler.h	View	4	1 chunk	+0 lines, -37 lines	0 comments	Download
D	chrome/browser/policy/url_blacklist_policy_handler.cc	View	4	1 chunk	+0 lines, -85 lines	0 comments	Download
M	chrome/browser/policy/url_blacklist_policy_handler_unittest.cc	View	1 2 4	1 chunk	+9 lines, -2 lines	0 comments	Download
M	chrome/chrome_browser.gypi	View	1 2 3 4	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/chrome_tests_unit.gypi	View	1 2 4	1 chunk	+0 lines, -1 line	0 comments	Download
M	components/components_tests.gyp	View	1 2 3 4	1 chunk	+1 line, -0 lines	0 comments	Download
M	components/policy/core/browser/DEPS	View	4	1 chunk	+1 line, -0 lines	0 comments	Download
A +	components/policy/core/browser/autofill_policy_handler.h	View	4	2 chunks	+5 lines, -8 lines	0 comments	Download
A +	components/policy/core/browser/autofill_policy_handler.cc	View	4	1 chunk	+1 line, -1 line	0 comments	Download
A +	components/policy/core/browser/autofill_policy_handler_unittest.cc	View	4	1 chunk	+1 line, -1 line	0 comments	Download
M	components/policy/core/browser/configuration_policy_handler.cc	View	4	1 chunk	+0 lines, -1 line	0 comments	Download
A +	components/policy/core/browser/url_blacklist_policy_handler.h	View	4	2 chunks	+6 lines, -9 lines	0 comments	Download
A +	components/policy/core/browser/url_blacklist_policy_handler.cc	View	4	1 chunk	+1 line, -1 line	0 comments	Download
M	components/policy/policy_browser.gypi	View	1 2 4	2 chunks	+7 lines, -0 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Joao da Silva

PTAL: @Daniel: policy stuff @Jochen: gyp stuff Thanks!

6 years, 11 months ago (2014-01-16 13:46:10 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/joaodasilva@chromium.org/140803003/390001

6 years, 11 months ago (2014-01-17 13:23:04 UTC) #4

Message was sent while issue was closed.

Change committed as 245522

Expand Messages | Collapse Messages