Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3)

Unified Diff: src/IceConverter.cpp

Issue 1408023004: Subzero: Add -allow-extern as an alias for --allow-externally-defined-symbols. (Closed) Base URL: https://chromium.googlesource.com/native_client/pnacl-subzero.git@master
Patch Set: Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/IceClFlags.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/IceConverter.cpp
diff --git a/src/IceConverter.cpp b/src/IceConverter.cpp
index 349fde54f676cabee6ff034bd856d333db6d1439..a84ae2cf69d4e2004ed508f82305a148c82619e7 100644
--- a/src/IceConverter.cpp
+++ b/src/IceConverter.cpp
@@ -872,6 +872,8 @@ void Converter::installGlobalDeclarations(Module *Mod) {
raw_string_ostream StrBuf(Buffer);
StrBuf << "Function " << IceFunc->getName()
<< " has incorrect linkage: " << IceFunc->getLinkageName();
+ if (IceFunc->isExternal())
+ StrBuf << "\n Use flag -allow-externally-defined-symbols to override";
report_fatal_error(StrBuf.str());
}
GlobalDeclarationMap[&Func] = IceFunc;
@@ -891,6 +893,8 @@ void Converter::installGlobalDeclarations(Module *Mod) {
raw_string_ostream StrBuf(Buffer);
StrBuf << "Global " << Var->getName()
<< " has incorrect linkage: " << Var->getLinkageName();
+ if (Var->isExternal())
+ StrBuf << "\n Use flag -allow-externally-defined-symbols to override";
report_fatal_error(StrBuf.str());
}
GlobalDeclarationMap[GV] = Var;
« no previous file with comments | « src/IceClFlags.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698