Issue 1408023004: Subzero: Add -allow-extern as an alias for --allow-externally-defined-symbols.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1408023004: Subzero: Add -allow-extern as an alias for --allow-externally-defined-symbols. (Closed)

Created:
5 years, 2 months ago by Jim Stichnoth

Modified:
5 years, 2 months ago

Reviewers:
sehr (please use chromium), Karl, John

CC:
native-client-reviews_googlegroups.com

Base URL:
https://chromium.googlesource.com/native_client/pnacl-subzero.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Subzero: Add -allow-extern as an alias for --allow-externally-defined-symbols. Also remind the user of that option in IceConverter.cpp, similar to PNaClTranslator.cpp. BUG= none R=kschimpf@google.com Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=4e10aa2cbd6eea4cee47e4bd20bd0c0b6887fbd0

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -1 line)			Patch
	M	src/IceClFlags.cpp	View		2 chunks	+5 lines, -1 line	0 comments	Download
	M	src/IceConverter.cpp	View		2 chunks	+4 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Jim Stichnoth

5 years, 2 months ago (2015-10-16 20:13:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4e10aa2cbd6eea4cee47e4bd20bd0c0b6887fbd0 (presubmit successful).