Don't persist registrations for whitelists installed from the command line.

Don't persist registrations for whitelists installed from the command line.

BUG=543971
Committed: https://crrev.com/506bb3196e890f9dfae522d1d29e53e4466d14ae
Cr-Commit-Position: refs/heads/master@{#356024}

[Bernhard Bauer, 2015-10-16 10:27:52]

bauerb@chromium.org changed reviewers:
+ sorin@chromium.org, treib@chromium.org

[Bernhard Bauer, 2015-10-16 10:27:52]

Please review. Thanks!

[Marc Treib, 2015-10-16 11:03:58]

LGTM

https://codereview.chromium.org/1408023003/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_whitelist_service.cc
(right):

https://codereview.chromium.org/1408023003/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_whitelist_service.cc:301:
client_id = client_id_;
nit: I'd have put this inline, like
(source == FROM_COMMAND_LINE) ? std::string() : client_id_
(but up to you)

[Bernhard Bauer, 2015-10-16 11:23:13]

https://codereview.chromium.org/1408023003/diff/1/chrome/browser/supervised_u...
File chrome/browser/supervised_user/supervised_user_whitelist_service.cc
(right):

https://codereview.chromium.org/1408023003/diff/1/chrome/browser/supervised_u...
chrome/browser/supervised_user/supervised_user_whitelist_service.cc:301:
client_id = client_id_;
On 2015/10/16 11:03:58, Marc Treib wrote:
> nit: I'd have put this inline, like
> (source == FROM_COMMAND_LINE) ? std::string() : client_id_
> (but up to you)

Done.

[Sorin Jianu, 2015-10-24 20:13:16]

lgtm

Thank you!

[Bernhard Bauer, 2015-10-26 09:34:50]

The CQ bit was checked by bauerb@chromium.org

[Bernhard Bauer, 2015-10-26 09:34:51]

The patchset sent to the CQ was uploaded after l-g-t-m from treib@chromium.org
Link to the patchset: https://codereview.chromium.org/1408023003/#ps20001
(title: "nit")

[commit-bot: I haz the power, 2015-10-26 09:35:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1408023003/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1408023003/20001

[commit-bot: I haz the power, 2015-10-26 11:20:11]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-10-26 11:21:24]

Patchset 2 (id:??) landed as
https://crrev.com/506bb3196e890f9dfae522d1d29e53e4466d14ae
Cr-Commit-Position: refs/heads/master@{#356024}