Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(535)

Issue 1408013005: Remove the define for SK_SAVE_LAYER_BOUNDS_ARE_FILTERED. (Closed)

Created:
5 years, 1 month ago by Stephen White
Modified:
5 years, 1 month ago
CC:
chromium-reviews, blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove the define for SK_SAVE_LAYER_BOUNDS_ARE_FILTERED. This new functionality in Skia means we no longer need to adjust for filter bounds in Chrome when calling saveLayer(). R=fmalita@google.com BUG=240827 Committed: https://crrev.com/225595c63bd59e143285e7e4034ff49e19ade62d Cr-Commit-Position: refs/heads/master@{#356693}

Patch Set 1 #

Patch Set 2 : Moar test expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -6 lines) Patch
M skia/config/SkUserConfig.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/LayoutTests/TestExpectations View 1 1 chunk +15 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Stephen White
Florin: PTAL. Thanks!
5 years, 1 month ago (2015-10-28 21:58:45 UTC) #1
f(malita)
On 2015/10/28 21:58:45, Stephen White wrote: > Florin: PTAL. Thanks! Assuming you've verified the diffs. ...
5 years, 1 month ago (2015-10-28 22:05:04 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408013005/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408013005/20001
5 years, 1 month ago (2015-10-28 22:44:34 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 1 month ago (2015-10-28 23:53:58 UTC) #6
commit-bot: I haz the power
5 years, 1 month ago (2015-10-28 23:54:47 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/225595c63bd59e143285e7e4034ff49e19ade62d
Cr-Commit-Position: refs/heads/master@{#356693}

Powered by Google App Engine
This is Rietveld 408576698