Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1408003012: Remove unused RegExp private symbols. (Closed)

Created:
5 years, 1 month ago by Yang
Modified:
5 years, 1 month ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove unused RegExp private symbols. R=ulan@chromium.org Committed: https://crrev.com/6e981a32a68df5f5c176c5c5045c6cecdd8b0a31 Cr-Commit-Position: refs/heads/master@{#31861}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -2 lines) Patch
M src/heap/heap.h View 1 chunk +0 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
Yang
5 years, 1 month ago (2015-11-05 06:45:30 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408003012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408003012/1
5 years, 1 month ago (2015-11-05 06:45:41 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 1 month ago (2015-11-05 07:22:40 UTC) #5
ulan
lgtm
5 years, 1 month ago (2015-11-06 14:38:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1408003012/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1408003012/1
5 years, 1 month ago (2015-11-06 14:43:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 1 month ago (2015-11-06 15:24:40 UTC) #9
commit-bot: I haz the power
5 years, 1 month ago (2015-11-06 15:25:28 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6e981a32a68df5f5c176c5c5045c6cecdd8b0a31
Cr-Commit-Position: refs/heads/master@{#31861}

Powered by Google App Engine
This is Rietveld 408576698