Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14080012: Do not display local overlay suggestion box if there are no suggestions. (Closed)

Created:
7 years, 8 months ago by kmadhusu
Modified:
7 years, 8 months ago
Reviewers:
samarth, Dan Beam
CC:
chromium-reviews, arv+watch_chromium.org
Visibility:
Public.

Description

Do not display local overlay suggestion box if there are no suggestions. BUG=229839 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=194375

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed review comment. #

Total comments: 4

Patch Set 3 : Use display:inline-block #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (0 generated)
kmadhusu
7 years, 8 months ago (2013-04-15 22:11:42 UTC) #1
samarth
LGTM, that was fast! https://codereview.chromium.org/14080012/diff/1/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css File chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css (right): https://codereview.chromium.org/14080012/diff/1/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css#newcode18 chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css:18: #suggestionsBox:empty { Please add a ...
7 years, 8 months ago (2013-04-15 22:49:10 UTC) #2
kmadhusu
https://codereview.chromium.org/14080012/diff/1/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css File chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css (right): https://codereview.chromium.org/14080012/diff/1/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css#newcode18 chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css:18: #suggestionsBox:empty { On 2013/04/15 22:49:10, samarth wrote: > Please ...
7 years, 8 months ago (2013-04-15 22:55:51 UTC) #3
Dan Beam
try this first https://codereview.chromium.org/14080012/diff/1002/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css File chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css (right): https://codereview.chromium.org/14080012/diff/1002/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css#newcode15 chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css:15: padding-top: 6px; display: inline-block; (http://jsfiddle.net/hV7Rv/)
7 years, 8 months ago (2013-04-15 23:05:51 UTC) #4
kmadhusu
https://codereview.chromium.org/14080012/diff/1002/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css File chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css (right): https://codereview.chromium.org/14080012/diff/1002/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css#newcode15 chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css:15: padding-top: 6px; On 2013/04/15 23:05:51, Dan Beam wrote: > ...
7 years, 8 months ago (2013-04-15 23:33:21 UTC) #5
Dan Beam
https://codereview.chromium.org/14080012/diff/1002/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css File chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css (right): https://codereview.chromium.org/14080012/diff/1002/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css#newcode15 chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css:15: padding-top: 6px; On 2013/04/15 23:33:21, kmadhusu wrote: > On ...
7 years, 8 months ago (2013-04-15 23:48:47 UTC) #6
kmadhusu
https://codereview.chromium.org/14080012/diff/1002/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css File chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css (right): https://codereview.chromium.org/14080012/diff/1002/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css#newcode15 chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css:15: padding-top: 6px; On 2013/04/15 23:48:48, Dan Beam wrote: > ...
7 years, 8 months ago (2013-04-15 23:59:57 UTC) #7
Dan Beam
lgtm https://codereview.chromium.org/14080012/diff/8001/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css File chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css (right): https://codereview.chromium.org/14080012/diff/8001/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css#newcode16 chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css:16: display: inline-block; alphabetize
7 years, 8 months ago (2013-04-16 00:06:47 UTC) #8
kmadhusu
https://codereview.chromium.org/14080012/diff/8001/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css File chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css (right): https://codereview.chromium.org/14080012/diff/8001/chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css#newcode16 chrome/browser/resources/local_omnibox_popup/local_omnibox_popup.css:16: display: inline-block; On 2013/04/16 00:06:47, Dan Beam wrote: > ...
7 years, 8 months ago (2013-04-16 13:03:27 UTC) #9
kmadhusu
7 years, 8 months ago (2013-04-16 17:02:38 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 manually as r194375 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698