Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1137)

Unified Diff: chrome/browser/extensions/extension_web_ui.cc

Issue 14080004: Remove some chrome-specific methods from content::WebUI. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: fix browser_test Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/extension_web_ui.cc
===================================================================
--- chrome/browser/extensions/extension_web_ui.cc (revision 193436)
+++ chrome/browser/extensions/extension_web_ui.cc (working copy)
@@ -131,9 +131,6 @@
const Extension* extension =
service->extensions()->GetExtensionOrAppByURL(ExtensionURLInfo(url));
DCHECK(extension);
- // Only hide the url for internal pages (e.g. chrome-extension or packaged
- // component apps like bookmark manager.
- bool should_hide_url = !extension->is_hosted_app();
// The base class defaults to enabling WebUI bindings, but we don't need
// those (this is also reflected in ChromeWebUIControllerFactory::
@@ -144,20 +141,6 @@
const CommandLine& browser_command_line = *CommandLine::ForCurrentProcess();
if (browser_command_line.HasSwitch(switches::kChromeFrame))
bindings |= content::BINDINGS_POLICY_EXTERNAL_HOST;
- // For chrome:// overrides, some of the defaults are a little different.
- GURL effective_url = web_ui->GetWebContents()->GetURL();
- if (effective_url.SchemeIs(chrome::kChromeUIScheme)) {
- if (effective_url.host() == chrome::kChromeUINewTabHost) {
- web_ui->FocusLocationBarByDefault();
- } else {
- // Current behavior of other chrome:// pages is to display the URL.
- should_hide_url = false;
- }
- }
-
- if (should_hide_url)
- web_ui->HideURL();
-
web_ui->SetBindings(bindings);
// Hack: A few things we specialize just for the bookmark manager.
« no previous file with comments | « no previous file | chrome/browser/favicon/favicon_tab_helper.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698