Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/webui/sync_setup_handler_unittest.cc

Issue 14080004: Remove some chrome-specific methods from content::WebUI. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments and fix null check Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/toolbar/toolbar_model_impl.cc ('K') | « chrome/browser/ui/webui/ntp/new_tab_ui.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/sync_setup_handler_unittest.cc
===================================================================
--- chrome/browser/ui/webui/sync_setup_handler_unittest.cc (revision 193436)
+++ chrome/browser/ui/webui/sync_setup_handler_unittest.cc (working copy)
@@ -245,18 +245,6 @@
virtual ui::ScaleFactor GetDeviceScaleFactor() const OVERRIDE {
return ui::SCALE_FACTOR_100P;
}
- virtual bool ShouldHideFavicon() const OVERRIDE {
- return false;
- }
- virtual void HideFavicon() OVERRIDE {}
- virtual bool ShouldFocusLocationBarByDefault() const OVERRIDE {
- return false;
- }
- virtual void FocusLocationBarByDefault() OVERRIDE {}
- virtual bool ShouldHideURL() const OVERRIDE {
- return false;
- }
- virtual void HideURL() OVERRIDE {}
virtual const string16& GetOverriddenTitle() const OVERRIDE {
return temp_string_;
}
« chrome/browser/ui/toolbar/toolbar_model_impl.cc ('K') | « chrome/browser/ui/webui/ntp/new_tab_ui.cc ('k') | content/browser/web_contents/web_contents_impl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698