Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/favicon/favicon_tab_helper.cc

Issue 14080004: Remove some chrome-specific methods from content::WebUI. (Closed) Base URL: svn://chrome-svn/chrome/trunk/src/
Patch Set: review comments and fix null check Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/toolbar/toolbar_model_impl.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/favicon/favicon_tab_helper.cc
===================================================================
--- chrome/browser/favicon/favicon_tab_helper.cc (revision 193436)
+++ chrome/browser/favicon/favicon_tab_helper.cc (working copy)
@@ -22,7 +22,6 @@
#include "content/public/browser/render_view_host.h"
#include "content/public/browser/web_contents.h"
#include "content/public/browser/web_contents_delegate.h"
-#include "content/public/browser/web_ui.h"
#include "ui/gfx/codec/png_codec.h"
#include "ui/gfx/image/image.h"
#include "ui/gfx/image/image_skia.h"
@@ -95,9 +94,6 @@
if (chrome::IsInstantNTP(web_contents()))
return false;
- content::WebUI* web_ui = web_contents()->GetWebUIForCurrentState();
- if (web_ui)
- return !web_ui->ShouldHideFavicon();
return true;
}
« no previous file with comments | « chrome/browser/extensions/extension_web_ui.cc ('k') | chrome/browser/ui/browser.cc » ('j') | chrome/browser/ui/toolbar/toolbar_model_impl.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698