Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Unified Diff: gm/gm_expectations.h

Issue 14080003: GM: remove enableMissingWarning in favor of verbose flag, and trim output in nonverbose mode (Closed) Base URL: http://skia.googlecode.com/svn/trunk/
Patch Set: Created 7 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | gm/gmmain.cpp » ('j') | gm/tests/outputs/compared-against-empty-dir/output-expected/stderr » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: gm/gm_expectations.h
===================================================================
--- gm/gm_expectations.h (revision 8593)
+++ gm/gm_expectations.h (working copy)
@@ -225,12 +225,8 @@
*
* rootDir: directory under which to look for image files
* (this string will be copied to storage within this object)
- * notifyOfMissingFiles: whether to log a message to stderr if an image
- * file cannot be found
*/
- IndividualImageExpectationsSource(const char *rootDir,
- bool notifyOfMissingFiles) :
- fRootDir(rootDir), fNotifyOfMissingFiles(notifyOfMissingFiles) {}
+ IndividualImageExpectationsSource(const char *rootDir) : fRootDir(rootDir) {}
Expectations get(const char *testName) SK_OVERRIDE {
SkString path = make_filename(fRootDir.c_str(), "", testName,
@@ -244,16 +240,12 @@
if (decodedReferenceBitmap) {
return Expectations(referenceBitmap);
} else {
- if (fNotifyOfMissingFiles) {
- gm_fprintf(stderr, "FAILED to read %s\n", path.c_str());
- }
return Expectations();
}
}
private:
const SkString fRootDir;
- const bool fNotifyOfMissingFiles;
};
/**
« no previous file with comments | « no previous file | gm/gmmain.cpp » ('j') | gm/tests/outputs/compared-against-empty-dir/output-expected/stderr » ('J')

Powered by Google App Engine
This is Rietveld 408576698