Issue 14080003: GM: remove enableMissingWarning in favor of verbose flag, and trim output in nonverbose mode

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14080003: GM: remove enableMissingWarning in favor of verbose flag, and trim output in nonverbose mode (Closed)

Created:
7 years, 8 months ago by epoger

Modified:
7 years, 8 months ago

Reviewers:
reed1

CC:
skia-review_googlegroups.com

Base URL:
http://skia.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

GM: remove enableMissingWarning in favor of verbose flag, and trim output in nonverbose mode Committed: https://code.google.com/p/skia/source/detail?r=8600

Patch Set 1 #

Total comments: 1

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+29 lines, -37 lines)			Patch
M	gm/gm_expectations.h	View	2 chunks	+1 line, -9 lines	0 comments	Download
M	gm/gmmain.cpp	View	6 chunks	+28 lines, -22 lines	0 comments	Download
M	gm/tests/outputs/compared-against-empty-dir/output-expected/stderr	View	1 chunk	+0 lines, -2 lines	1 comment	Download
M	gm/tests/outputs/nonverbose/output-expected/stderr	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	gm/tests/outputs/nonverbose/output-expected/stdout	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

epoger

https://codereview.chromium.org/14080003/diff/1/gm/tests/outputs/compared-against-empty-dir/output-expected/stderr File gm/tests/outputs/compared-against-empty-dir/output-expected/stderr (left): https://codereview.chromium.org/14080003/diff/1/gm/tests/outputs/compared-against-empty-dir/output-expected/stderr#oldcode1 gm/tests/outputs/compared-against-empty-dir/output-expected/stderr:1: GM: FAILED to read gm/tests/inputs/images/empty-dir/8888/selftest1.png We already list these ...

7 years, 8 months ago (2013-04-10 18:02:31 UTC) #1

epoger

7 years, 8 months ago (2013-04-10 18:46:31 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r8600 (presubmit successful).

Expand Messages | Collapse Messages