Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(200)

Issue 1407953004: [turbofan] Use ReturnId for lazy bailout of JSCallFunction. (Closed)

Created:
5 years, 2 months ago by Benedikt Meurer
Modified:
5 years, 2 months ago
Reviewers:
Jarin
CC:
v8-reviews_googlegroups.com, Michael Starzinger
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Use ReturnId for lazy bailout of JSCallFunction. We need to use the ReturnId for calls, otherwise lazy bailout will not work correctly in case of inlining. R=jarin@chromium.org BUG=v8:4493 LOG=n Committed: https://crrev.com/683c17a4a4e5b14a976fc8a31920f08f588fb804 Cr-Commit-Position: refs/heads/master@{#31401}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M src/compiler/ast-graph-builder.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (1 generated)
Benedikt Meurer
5 years, 2 months ago (2015-10-20 08:32:46 UTC) #1
Benedikt Meurer
Hey Jaro, Here's the fix we cooked. Please take a look. Thanks, Benedikt
5 years, 2 months ago (2015-10-20 08:33:18 UTC) #2
Jarin
lgtm
5 years, 2 months ago (2015-10-20 08:34:31 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407953004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407953004/1
5 years, 2 months ago (2015-10-20 08:34:48 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 2 months ago (2015-10-20 08:53:43 UTC) #6
commit-bot: I haz the power
5 years, 2 months ago (2015-10-20 08:54:10 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/683c17a4a4e5b14a976fc8a31920f08f588fb804
Cr-Commit-Position: refs/heads/master@{#31401}

Powered by Google App Engine
This is Rietveld 408576698