Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(165)

Issue 140793012: Revert of Update of change event for input type number (Closed)

Created:
6 years, 11 months ago by tkent
Modified:
6 years, 11 months ago
Reviewers:
keishi, Habib Virji
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Revert of Update of change event for input type number (https://codereview.chromium.org/128133002/) Reason for revert: I'm afraid It made time-multiple-fields-spinbutton-change-and-input-events.html flaky. Original issue's description: > Do not dispatch 'change' events during pressing spin buttons for input[type=number]. > > TextFieldInputType sends change event for its derived class. Change is > done for DispatchInputAndChangeEvent to behave similar to > DispatchChangeEvent. > DispatchChangeEvent is generated by Range, Radio, File and Checkbox > input type. > DispatchInputAndChangeEvent is generated by inputtype for step up and > down, BaseChooser/BaseMultipleFieldsDateandTime also generates > DispatchInputAndChangeEvent. > Since it is different set of inputs that generate DispatchChange and > DispatchInputAndChange, both are kept but behavior is changed; this > allows spin button to handle mouseup event. > Keyboard events are also handled for spin button. > > R=tkent > BUG=155747 > TEST=automated > > Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165300 TBR=keishi@chromium.org,habib.virji@samsung.com NOTREECHECKS=true NOTRY=true BUG=155747

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -68 lines) Patch
D LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/forms/number/number-spinbutton-changeevent-trigger-expected.txt View 1 chunk +0 lines, -10 lines 0 comments Download
M LayoutTests/fast/forms/number/number-type-update-by-change-event.html View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/BaseMultipleFieldsDateAndTimeInputType.cpp View 1 chunk +0 lines, -5 lines 0 comments Download
M Source/core/html/forms/InputType.cpp View 2 chunks +5 lines, -5 lines 0 comments Download
M Source/core/html/forms/TextFieldInputType.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/html/shadow/SpinButtonElement.h View 1 chunk +0 lines, -1 line 0 comments Download
M Source/core/html/shadow/SpinButtonElement.cpp View 2 chunks +3 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
tkent
Created Revert of Update of change event for input type number
6 years, 11 months ago (2014-01-20 03:44:12 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tkent@chromium.org/140793012/1
6 years, 11 months ago (2014-01-20 03:44:20 UTC) #2
commit-bot: I haz the power
Change committed as 165376
6 years, 11 months ago (2014-01-20 03:44:38 UTC) #3
tkent
6 years, 11 months ago (2014-01-20 04:30:59 UTC) #4
Message was sent while issue was closed.
A revert of this CL has been created in
https://codereview.chromium.org/131513008/ by tkent@chromium.org.

The reason for reverting is: The revert didn't help.
.

Powered by Google App Engine
This is Rietveld 408576698