Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(54)

Issue 140793002: Add UMA actions for launching the plugin loader utility process. (Closed)

Created:
6 years, 11 months ago by Bernhard Bauer
Modified:
6 years, 11 months ago
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org
Visibility:
Public.

Description

Add UMA actions for launching the plugin loader utility process. BUG=171404 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245322

Patch Set 1 #

Total comments: 1

Patch Set 2 : x #

Patch Set 3 : review #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -0 lines) Patch
M content/browser/plugin_loader_posix.cc View 1 2 3 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
Bernhard Bauer
6 years, 11 months ago (2014-01-16 12:22:14 UTC) #1
jochen (gone - plz use gerrit)
lgtm https://codereview.chromium.org/140793002/diff/1/content/browser/plugin_loader_posix.cc File content/browser/plugin_loader_posix.cc (right): https://codereview.chromium.org/140793002/diff/1/content/browser/plugin_loader_posix.cc#newcode20 content/browser/plugin_loader_posix.cc:20: using base::UserMetricsAction; i don't think it's necessary to ...
6 years, 11 months ago (2014-01-16 15:32:50 UTC) #2
jochen (gone - plz use gerrit)
or even better, just use content::RecordAction :)
6 years, 11 months ago (2014-01-16 15:35:08 UTC) #3
Bernhard Bauer
On 2014/01/16 15:35:08, jochen wrote: > or even better, just use content::RecordAction :) done, and ...
6 years, 11 months ago (2014-01-16 15:37:10 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bauerb@chromium.org/140793002/130001
6 years, 11 months ago (2014-01-16 15:59:07 UTC) #5
jam
(removing myself as reviewer since Jochen reviewed)
6 years, 11 months ago (2014-01-16 16:38:23 UTC) #6
commit-bot: I haz the power
6 years, 11 months ago (2014-01-16 21:09:38 UTC) #7
Message was sent while issue was closed.
Change committed as 245322

Powered by Google App Engine
This is Rietveld 408576698