Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issue 1407923009: move TypeSystem classes to their own file (Closed)

Created:
5 years, 1 month ago by Jennifer Messerly
Modified:
5 years, 1 month ago
Reviewers:
Leaf, Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

move TypeSystem classes to their own file also sorted members per analyzer style (?) figured it would be easier to work on as a 0.5k file vs ~15k resolver.dart :) For now I left TypeProvider where it was. Not sure if it should move here or into its own file as well. For backwards compat, all of the types are re-exported from resolver.dart. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/4c44096bf68d1446160d89f0e6c43e46b9ceed4b

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+460 lines, -442 lines) Patch
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 5 chunks +4 lines, -440 lines 0 comments Download
A pkg/analyzer/lib/src/generated/type_system.dart View 1 chunk +451 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/task/strong_mode.dart View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 7 (3 generated)
Jennifer Messerly
5 years, 1 month ago (2015-11-03 19:29:17 UTC) #4
Jennifer Messerly
BTW, no code changes here. It's 100% move.
5 years, 1 month ago (2015-11-03 19:29:38 UTC) #5
Brian Wilkerson
LGTM
5 years, 1 month ago (2015-11-03 19:36:39 UTC) #6
Jennifer Messerly
5 years, 1 month ago (2015-11-03 19:38:38 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4c44096bf68d1446160d89f0e6c43e46b9ceed4b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698