Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 1407903011: Better error message when missing new or const (Closed)

Created:
5 years, 1 month ago by Brian Wilkerson
Modified:
5 years, 1 month ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -0 lines) Patch
M pkg/analyzer/lib/src/generated/element_resolver.dart View 1 chunk +13 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 1 chunk +15 lines, -0 lines 0 comments Download
M pkg/analyzer/test/generated/static_type_warning_code_test.dart View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 1 month ago (2015-11-05 20:24:49 UTC) #2
scheglov
LGTM
5 years, 1 month ago (2015-11-05 20:26:51 UTC) #3
Brian Wilkerson
5 years, 1 month ago (2015-11-06 14:15:23 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
10eb0659c6a2641b39439182bc925b1245be19d2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698