Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1407903005: Remove external jpeg provider interface. (Closed)

Created:
5 years, 1 month ago by Tom Sepez
Modified:
5 years, 1 month ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Remove external jpeg provider interface. It is unused in PDFium. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/3d59bd9d66d01eb39c30742bce67fa0376cb4ea8

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -158 lines) Patch
M BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M core/include/fxcodec/fx_codec.h View 2 chunks +0 lines, -3 lines 1 comment Download
D core/include/fxcodec/fx_codec_provider.h View 1 chunk +0 lines, -74 lines 0 comments Download
M core/src/fxcodec/codec/codec_int.h View 2 chunks +13 lines, -15 lines 0 comments Download
M core/src/fxcodec/codec/fx_codec_jpeg.cpp View 18 chunks +3 lines, -64 lines 0 comments Download
M pdfium.gyp View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 5 (2 generated)
Tom Sepez
Lei, for review. https://codereview.chromium.org/1407903005/diff/1/core/include/fxcodec/fx_codec.h File core/include/fxcodec/fx_codec.h (left): https://codereview.chromium.org/1407903005/diff/1/core/include/fxcodec/fx_codec.h#oldcode160 core/include/fxcodec/fx_codec.h:160: virtual void SetPovider(IFX_JpegProvider* pJP) = 0; ...
5 years, 1 month ago (2015-10-29 21:55:14 UTC) #3
Lei Zhang
lgtm
5 years, 1 month ago (2015-10-30 06:08:57 UTC) #4
Tom Sepez
5 years, 1 month ago (2015-10-30 20:33:39 UTC) #5
Message was sent while issue was closed. 
Committed patchset #1 (id:1) manually as
3d59bd9d66d01eb39c30742bce67fa0376cb4ea8 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698