Move conditionals inside target_defaults.

Move conditionals inside target_defaults.

This CL moves the conditionals inside the target_defaults configuration. This
causes the -fPIC to get picked up and allows component=shared_library to build
correctly.

BUG=pdfium:218
R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/26268af2c1242dd173aea6dcbf763a36e734faf3

[dsinclair, 2015-10-15 20:19:59]

dsinclair@chromium.org changed reviewers:
+ thestig@chromium.org, tsepez@chromium.org

[dsinclair, 2015-10-15 20:19:59]

PTAL.

This allows the build to succeed for me with component=shared_library in my
GYP_DEFINES. I don't know a lot of GYP, so it should be reviewed by someone that
does know GYP, just not sure who that would be.

[Tom Sepez, 2015-10-15 20:25:50]

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:253: 'target_defaults': {
These target_defaults blocks may be redundant inside target_defaults.

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:270: 'target_conditions': [
But this may have to remain target_conditions even after pulling the
target_defaults above.

[Tom Sepez, 2015-10-15 20:26:57]

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:247: ['component=="shared_library"', {
We'd want to this to apply to a release build as well.  Does that happen?

[Tom Sepez, 2015-10-15 20:38:14]

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:247: ['component=="shared_library"', {
On 2015/10/15 20:26:56, Tom Sepez wrote:
> We'd want to this to apply to a release build as well.  Does that happen?

(I think it happens, but confirm).

[Tom Sepez, 2015-10-15 20:39:50]

Change description should probably read 'Move conditionals inside
target_defaults', since that's where its going, not just the debug config (I
can't line up braces very well it seems).

[dsinclair, 2015-10-15 21:02:14]

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:247: ['component=="shared_library"', {
On 2015/10/15 20:26:56, Tom Sepez wrote:
> We'd want to this to apply to a release build as well.  Does that happen?


Seems too, I'm able to complete 'ninja -C out/Release'.

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:253: 'target_defaults': {
On 2015/10/15 20:25:50, Tom Sepez wrote:
> These target_defaults blocks may be redundant inside target_defaults.

Done.

https://codereview.chromium.org/1407903002/diff/1/build/standalone.gypi#newco...
build/standalone.gypi:270: 'target_conditions': [
On 2015/10/15 20:25:50, Tom Sepez wrote:
> But this may have to remain target_conditions even after pulling the
> target_defaults above.

Done.

[Tom Sepez, 2015-10-15 22:10:06]

Thanks!!! Looks good, but let's get Lei's eyeballs on this too.

[Lei Zhang, 2015-10-16 01:30:36]

commit msg typo: "contionals"

[Lei Zhang, 2015-10-16 01:32:36]

lgtm

https://codereview.chromium.org/1407903002/diff/20001/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1407903002/diff/20001/build/standalone.gypi#n...
build/standalone.gypi:261: '_HAS_EXCEPTIONS=0',
Need an extra space indentation here and on the next line? Make sure there's no
tabs please.

[dsinclair, 2015-10-16 01:43:34]

https://codereview.chromium.org/1407903002/diff/20001/build/standalone.gypi
File build/standalone.gypi (right):

https://codereview.chromium.org/1407903002/diff/20001/build/standalone.gypi#n...
build/standalone.gypi:261: '_HAS_EXCEPTIONS=0',
On 2015/10/16 01:32:35, Lei Zhang wrote:
> Need an extra space indentation here and on the next line? Make sure there's
no
> tabs please.

Done.

As far as I can tell there are no tabs (all my editors should be inserting
spaces)

[dsinclair, 2015-10-16 01:43:55]

Committed patchset #3 (id:40001) manually as
26268af2c1242dd173aea6dcbf763a36e734faf3 (presubmit successful).