Issue 14079007: Cleaned up and fixed code comment handling a bit.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 14079007: Cleaned up and fixed code comment handling a bit. (Closed)

Created:
7 years, 8 months ago by Sven Panne

Modified:
7 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

More Reviews

Description

Cleaned up and fixed code comment handling a bit. * Let GCC check the arguments of LCodeGen::Coment. * Fixed a few call sites. * Made basic blocks a little bit more visible in the code output. * Sorted #includes. Committed: http://code.google.com/p/v8/source/detail?r=14331

Patch Set 1 #

Patch Set 2 : Improved printing of block separator on x64/ARM/MIPS, too #

Created: 7 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+32 lines, -35 lines)			Patch
M	src/arm/lithium-codegen-arm.h	View		2 chunks	+3 lines, -1 line	0 comments	Download
M	src/arm/lithium-codegen-arm.cc	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.h	View		2 chunks	+3 lines, -2 lines	0 comments	Download
M	src/ia32/lithium-codegen-ia32.cc	View		3 chunks	+5 lines, -7 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.h	View		2 chunks	+4 lines, -3 lines	0 comments	Download
M	src/mips/lithium-codegen-mips.cc	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download
M	src/x64/lithium-codegen-x64.h	View		2 chunks	+2 lines, -1 line	0 comments	Download
M	src/x64/lithium-codegen-x64.cc	View	1	3 chunks	+5 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Sven Panne

7 years, 8 months ago (2013-04-18 13:45:41 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r14331 (presubmit successful).

Expand Messages | Collapse Messages