Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(327)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 14079005: Do not return file descriptor if target is a directory in IsolatedFileSystem (Closed)

Created:
7 years, 8 months ago by kinuko
Modified:
7 years, 8 months ago
Reviewers:
victorhsieh, nhiroki, tzik
CC:
chromium-reviews, tzik+watch_chromium.org, kinuko+watch, darin-cc_chromium.org, victorhsieh
Visibility:
Public.

Description

Do not return file descriptor if target is a directory in IsolatedFileSystem BUG=233029 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=195171

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M webkit/fileapi/native_file_util.cc View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
kinuko
I think this fixes the issue 233029, though we don't have the live code for ...
7 years, 8 months ago (2013-04-18 12:20:45 UTC) #1
tzik
lgtm
7 years, 8 months ago (2013-04-18 14:35:31 UTC) #2
victorhsieh
lgtm Verified that it works for my change. Thanks for quick fix!
7 years, 8 months ago (2013-04-18 17:33:41 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/14079005/1
7 years, 8 months ago (2013-04-19 00:41:28 UTC) #4
commit-bot: I haz the power
7 years, 8 months ago (2013-04-19 13:48:47 UTC) #5
Message was sent while issue was closed. 
Change committed as 195171

Powered by Google App Engine
This is Rietveld 408576698