Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Side by Side Diff: chrome/browser/about_flags.cc

Issue 1407883005: Added field trial for enabling AppContainer and a chrome://flags entry. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/about_flags.h" 5 #include "chrome/browser/about_flags.h"
6 6
7 #include <iterator> 7 #include <iterator>
8 #include <map> 8 #include <map>
9 #include <set> 9 #include <set>
10 #include <utility> 10 #include <utility>
(...skipping 2104 matching lines...) Expand 10 before | Expand all | Expand 10 after
2115 MULTI_VALUE_TYPE(kPpapiWin32kLockdown)}, 2115 MULTI_VALUE_TYPE(kPpapiWin32kLockdown)},
2116 #endif // defined(OS_WIN) 2116 #endif // defined(OS_WIN)
2117 #if defined(ENABLE_NOTIFICATIONS) && defined(OS_ANDROID) 2117 #if defined(ENABLE_NOTIFICATIONS) && defined(OS_ANDROID)
2118 {"enable-web-notification-custom-layouts", 2118 {"enable-web-notification-custom-layouts",
2119 IDS_FLAGS_ENABLE_WEB_NOTIFICATION_CUSTOM_LAYOUTS_NAME, 2119 IDS_FLAGS_ENABLE_WEB_NOTIFICATION_CUSTOM_LAYOUTS_NAME,
2120 IDS_FLAGS_ENABLE_WEB_NOTIFICATION_CUSTOM_LAYOUTS_DESCRIPTION, 2120 IDS_FLAGS_ENABLE_WEB_NOTIFICATION_CUSTOM_LAYOUTS_DESCRIPTION,
2121 kOsAndroid, 2121 kOsAndroid,
2122 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableWebNotificationCustomLayouts, 2122 ENABLE_DISABLE_VALUE_TYPE(switches::kEnableWebNotificationCustomLayouts,
2123 switches::kDisableWebNotificationCustomLayouts)}, 2123 switches::kDisableWebNotificationCustomLayouts)},
2124 #endif // defined(ENABLE_NOTIFICATIONS) && defined(OS_ANDROID) 2124 #endif // defined(ENABLE_NOTIFICATIONS) && defined(OS_ANDROID)
2125 #if defined(OS_WIN)
2126 {"enable-appcontainer", IDS_FLAGS_ENABLE_APPCONTAINER_NAME,
2127 IDS_FLAGS_ENABLE_APPCONTAINER_DESCRIPTION, kOsWin,
2128 SINGLE_VALUE_TYPE(switches::kEnableAppContainer)},
Alexei Svitkine (slow) 2015/11/02 18:58:55 Suggest making this ENABLE_DISABLE_VALUE_TYPE() wi
2129 #endif // defined(OS_WIN)
2125 // NOTE: Adding new command-line switches requires adding corresponding 2130 // NOTE: Adding new command-line switches requires adding corresponding
2126 // entries to enum "LoginCustomFlags" in histograms.xml. See note in 2131 // entries to enum "LoginCustomFlags" in histograms.xml. See note in
2127 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test. 2132 // histograms.xml and don't forget to run AboutFlagsHistogramTest unit test.
2128 }; 2133 };
2129 2134
2130 // Stores and encapsulates the little state that about:flags has. 2135 // Stores and encapsulates the little state that about:flags has.
2131 class FlagsState { 2136 class FlagsState {
2132 public: 2137 public:
2133 FlagsState() 2138 FlagsState()
2134 : feature_entries(kFeatureEntries), 2139 : feature_entries(kFeatureEntries),
(...skipping 829 matching lines...) Expand 10 before | Expand all | Expand 10 after
2964 FlagsState::GetInstance()->SetFeatureEntries(entries, count); 2969 FlagsState::GetInstance()->SetFeatureEntries(entries, count);
2965 } 2970 }
2966 2971
2967 const FeatureEntry* GetFeatureEntries(size_t* count) { 2972 const FeatureEntry* GetFeatureEntries(size_t* count) {
2968 return FlagsState::GetInstance()->GetFeatureEntries(count); 2973 return FlagsState::GetInstance()->GetFeatureEntries(count);
2969 } 2974 }
2970 2975
2971 } // namespace testing 2976 } // namespace testing
2972 2977
2973 } // namespace about_flags 2978 } // namespace about_flags
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698