Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Issue 1407863004: Index library/part file references from import/export/part containing files. (Closed)

Created:
5 years, 2 months ago by scheglov
Modified:
5 years, 2 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Index library/part file references from import/export/part containing files. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/af4fbdd9528a6411ea1f1c29f3beccdc0ae093b7

Patch Set 1 #

Total comments: 4

Patch Set 2 : tweaks #

Unified diffs Side-by-side diffs Delta from patch set Stats (+243 lines, -35 lines) Patch
M pkg/analysis_server/lib/src/services/index/index_contributor.dart View 7 chunks +21 lines, -4 lines 0 comments Download
A pkg/analysis_server/lib/src/services/index/indexable_file.dart View 1 1 chunk +74 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/index/dart_index_contributor_test.dart View 9 chunks +88 lines, -31 lines 0 comments Download
A pkg/analysis_server/test/services/index/indexable_file_test.dart View 1 1 chunk +58 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/index/test_all.dart View 2 chunks +2 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 2 months ago (2015-10-18 01:31:24 UTC) #1
Brian Wilkerson
LGTM https://codereview.chromium.org/1407863004/diff/1/pkg/analysis_server/lib/src/services/index/indexable_file.dart File pkg/analysis_server/lib/src/services/index/indexable_file.dart (right): https://codereview.chromium.org/1407863004/diff/1/pkg/analysis_server/lib/src/services/index/indexable_file.dart#newcode1 pkg/analysis_server/lib/src/services/index/indexable_file.dart:1: // Copyright (c) 2014, the Dart project authors. ...
5 years, 2 months ago (2015-10-18 15:41:08 UTC) #2
scheglov
5 years, 2 months ago (2015-10-18 17:24:58 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
af4fbdd9528a6411ea1f1c29f3beccdc0ae093b7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698