Issue 1407833002: Fix -Winconsistent-missing-override in SkCodec_libgif.h

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1407833002: Fix -Winconsistent-missing-override in SkCodec_libgif.h (Closed)

Created:
5 years, 2 months ago by mtklein_C

Modified:
5 years, 2 months ago

Reviewers:
msarett

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Fix -Winconsistent-missing-override in SkCodec_libgif.h Follow up to https://codereview.chromium.org/1400343005 This warning only triggers on a few configs, like the coverage bot. TBR=msarett@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/e9759286e8eb3a0ce00923bf9462818bc67cd9f8

Patch Set 1 #

Created: 5 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/codec/SkCodec_libgif.h	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407833002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407833002/1

5 years, 2 months ago (2015-10-15 15:43:59 UTC) #4

commit-bot: I haz the power

5 years, 2 months ago (2015-10-15 15:55:37 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/e9759286e8eb3a0ce00923bf9462818bc67cd9f8

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages