Issue 140783009: Revert 245464 "Use an alternate mechanism for CreateFile calls i..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140783009: Revert 245464 "Use an alternate mechanism for CreateFile calls i..." (Closed)

Created:
6 years, 11 months ago by jochen (gone - plz use gerrit)

Modified:
6 years, 11 months ago

Reviewers:
Cait (Slow)

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

Revert 245464 "Use an alternate mechanism for CreateFile calls i..." ChromeCreateFileTest.CheckWriteAndReadParams crashes on Vista > Use an alternate mechanism for CreateFile calls in Chrome > > BUG=334379 > > Review URL: https://codereview.chromium.org/138593004 TBR=caitkp@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245501

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+1 line, -713 lines)			Patch
M	trunk/src/build/common.gypi	View	1 chunk	+0 lines, -7 lines	0 comments	Download
M	trunk/src/chrome/chrome_dll.gypi	View	2 chunks	+0 lines, -12 lines	0 comments	Download
M	trunk/src/chrome/chrome_exe.gypi	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome_elf/chrome_elf.def	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	trunk/src/chrome_elf/chrome_elf.gyp	View	4 chunks	+1 line, -45 lines	0 comments	Download
D	trunk/src/chrome_elf/chrome_elf_constants.h	View	1 chunk	+0 lines, -14 lines	0 comments	Download
D	trunk/src/chrome_elf/chrome_elf_constants.cc	View	1 chunk	+0 lines, -13 lines	0 comments	Download
D	trunk/src/chrome_elf/chrome_redirects.def	View	1 chunk	+0 lines, -8 lines	0 comments	Download
D	trunk/src/chrome_elf/create_file/chrome_create_file.h	View	1 chunk	+0 lines, -38 lines	0 comments	Download
D	trunk/src/chrome_elf/create_file/chrome_create_file.cc	View	1 chunk	+0 lines, -237 lines	0 comments	Download
D	trunk/src/chrome_elf/create_file/chrome_create_file_unittest.cc	View	1 chunk	+0 lines, -327 lines	0 comments	Download
M	trunk/src/sandbox/win/src/nt_internals.h	View	2 chunks	+0 lines, -10 lines	0 comments	Download

Total messages: 2 (0 generated)

jochen (gone - plz use gerrit)

6 years, 11 months ago (2014-01-17 12:49:42 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r245501 (tree was closed).