Issue 140783007: Remove custom V8 bindings for MIDI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 140783007: Remove custom V8 bindings for MIDI (Closed)

Created:
6 years, 11 months ago by haraken

Modified:
6 years, 11 months ago

Reviewers:
Takashi Toyoshima, kouhei (in TOK)

CC:
blink-reviews, kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, Inactive

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

More Reviews

Description

Remove custom V8 bindings for MIDI We can remove the custom bindings using [SetReference]. [SetReference] generates code that is semantically the same as the custom bindings. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=165286

Patch Set 1 #

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+2 lines, -108 lines)			Patch
M	Source/bindings/bindings.gypi	View	1 chunk	+0 lines, -2 lines	0 comments	Download
D	Source/bindings/v8/custom/V8MIDIInputCustom.cpp	View	1 chunk	+0 lines, -52 lines	0 comments	Download
D	Source/bindings/v8/custom/V8MIDIOutputCustom.cpp	View	1 chunk	+0 lines, -52 lines	0 comments	Download
M	Source/modules/webmidi/MIDIInput.idl	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/modules/webmidi/MIDIOutput.idl	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/140783007/1

6 years, 11 months ago (2014-01-17 06:48:51 UTC) #3

Nils Barth (inactive)

BTW, a high-five for the good design on [SetReference]! (Replacing existing custom code even outside ...

6 years, 11 months ago (2014-01-17 06:50:47 UTC) #4

Message was sent while issue was closed.

Change committed as 165286

Expand Messages | Collapse Messages