Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(19)

Issue 140783006: drive: Support authorizing third-party Drive apps for opening files. (Closed)

Created:
6 years, 11 months ago by kinaba
Modified:
6 years, 11 months ago
Reviewers:
hashimoto
CC:
chromium-reviews
Visibility:
Public.

Description

drive: Support authorizing third-party Drive apps for opening files. Along the way, replace the official key check in DriveAppRegistry::IsUninstallSupported by the new devoted function. (In fact, the macro is available only during google_apis/ hence the previous code was not working well...) BUG=332332 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=245565

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -14 lines) Patch
M chrome/browser/drive/drive_api_service.cc View 2 chunks +23 lines, -6 lines 0 comments Download
M chrome/browser/drive/drive_app_registry.cc View 2 chunks +2 lines, -5 lines 0 comments Download
M google_apis/drive/drive_api_requests.h View 1 chunk +32 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_requests.cc View 1 chunk +23 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_url_generator.h View 1 chunk +4 lines, -0 lines 0 comments Download
M google_apis/drive/drive_api_url_generator.cc View 3 chunks +14 lines, -3 lines 0 comments Download
M google_apis/drive/drive_api_url_generator_unittest.cc View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
kinaba
PTAL. Note that it depends on https://codereview.chromium.org/131743018/. This is yet another undocumented API, but what ...
6 years, 11 months ago (2014-01-17 09:00:44 UTC) #1
hashimoto
lgtm
6 years, 11 months ago (2014-01-17 09:50:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/140783006/130001
6 years, 11 months ago (2014-01-17 13:59:53 UTC) #3
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) app_list_unittests, ash_unittests, aura_unittests, cacheinvalidation_unittests, cc_unittests, check_deps, ...
6 years, 11 months ago (2014-01-17 14:44:31 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/140783006/130001
6 years, 11 months ago (2014-01-17 15:01:58 UTC) #5
commit-bot: I haz the power
6 years, 11 months ago (2014-01-17 18:33:32 UTC) #6
Message was sent while issue was closed.
Change committed as 245565

Powered by Google App Engine
This is Rietveld 408576698