Handle missing $HOME case in download path migration code for multi-profile.

chrome/browser/chromeos/file_manager/path_util.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/chromeos/file_manager/path_util.h"
 
 #include "base/files/file_path.h"
 #include "base/logging.h"
 #include "base/path_service.h"
 #include "base/sys_info.h"
 #include "chrome/browser/chromeos/drive/file_system_util.h"
+#include "chrome/browser/download/download_prefs.h"
 #include "chrome/browser/profiles/profile.h"
 
 namespace file_manager {
 namespace util {
 
 const char kDownloadsFolderName[] = "Downloads";
 const base::FilePath::CharType kOldDownloadsFolderPath[] =
     FILE_PATH_LITERAL("/home/chronos/user/Downloads");
 
 base::FilePath GetDownloadsFolderForProfile(Profile* profile) {
@@ skipping 11 matching lines @@
 bool MigratePathFromOldFormat(Profile* profile,
                               const base::FilePath& old_path,
                               base::FilePath* new_path) {
   // /special/drive/xxx => /special/drive/root/xxx
   if (drive::util::NeedsNamespaceMigration(old_path)) {
     *new_path = drive::util::ConvertToMyDriveNamespace(old_path);
     return true;
   }
 
   // /home/chronos/user/Downloads/xxx => /home/chronos/u-hash/Downloads/xxx
-  const base::FilePath old_base(kOldDownloadsFolderPath);
-  base::FilePath relative;
-  if (old_path == old_base ||
-      old_base.AppendRelativePath(old_path, &relative)) {
-    const base::FilePath new_base = GetDownloadsFolderForProfile(profile);
-    *new_path = new_base.Append(relative);
-    return old_path != *new_path;
+  //
+  // Old path format comes either from stored old settings or from the initial
+  // default value set in DownloadPrefs::RegisterProfilePrefs in profile-unaware
+  // code location. In the former case it is "/home/chronos/user/Downloads",
+  // and in the latter case it is DownloadPrefs::GetDefaultDownloadDirectory().
+  // Those two paths coincides as long as $HOME=/home/chronos/user, but the
+  // environment variable is phasing out (crbug.com/333031) so we care both.
+  const base::FilePath old_bases[] = {
+      base::FilePath(kOldDownloadsFolderPath),
+      DownloadPrefs::GetDefaultDownloadDirectory(),
+  };
+  for (size_t i = 0; i < arraysize(old_bases); ++i) {
+    const base::FilePath& old_base = old_bases[i];
+    base::FilePath relative;
+    if (old_path == old_base ||
+        old_base.AppendRelativePath(old_path, &relative)) {
+      const base::FilePath new_base = GetDownloadsFolderForProfile(profile);
+      *new_path = new_base.Append(relative);
+      return old_path != *new_path;
+    }
   }
 
   return false;
 }
 
-
 }  // namespace util
 }  // namespace file_manager