content/renderer/pepper/pepper_media_stream_video_track_host.cc - Issue 140783004: [PPAPI] Pepper MediaStream API audio track implementation and example.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_media_stream_video_track_host.cc

Issue 140783004: [PPAPI] Pepper MediaStream API audio track implementation and example. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review issues Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/renderer/pepper/pepper_media_stream_track_host_base.cc ('k') | content/renderer/pepper/resource_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_media_stream_video_track_host.cc

diff --git a/content/renderer/pepper/pepper_media_stream_video_track_host.cc b/content/renderer/pepper/pepper_media_stream_video_track_host.cc

index 8996ef6683362933459e37206860fa0a02c069aa..0cf8036c9a5555f9c774dfb68c26d19efe9269ba 100644

--- a/content/renderer/pepper/pepper_media_stream_video_track_host.cc

+++ b/content/renderer/pepper/pepper_media_stream_video_track_host.cc

@@ -78,7 +78,9 @@ void PepperMediaStreamVideoTrackHost::OnVideoFrame(

DCHECK(!frame_data_size_);

frame_data_size_ = VideoFrame::AllocationSize(frame_format_, frame_size_);

int32_t size = sizeof(ppapi::MediaStreamFrame::Video) + frame_data_size_;

- InitFrames(kNumberOfFrames, size);

+ bool result = InitFrames(kNumberOfFrames, size);

+ // TODO(penghuang): Send PP_ERROR_NOMEMORY to plugin.

+ CHECK(result);

}

int32_t index = frame_buffer()->DequeueFrame();

« no previous file with comments | « content/renderer/pepper/pepper_media_stream_track_host_base.cc ('k') | content/renderer/pepper/resource_converter.cc » ('j') | no next file with comments »