content/renderer/pepper/pepper_media_stream_track_host_base.cc - Issue 140783004: [PPAPI] Pepper MediaStream API audio track implementation and example.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/pepper/pepper_media_stream_track_host_base.cc

Issue 140783004: [PPAPI] Pepper MediaStream API audio track implementation and example. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix review issues Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« content/renderer/pepper/pepper_media_stream_audio_track_host.cc ('K') | « content/renderer/pepper/pepper_media_stream_audio_track_host.cc ('k') | content/renderer/pepper/resource_converter.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/renderer/pepper/pepper_media_stream_track_host_base.cc

diff --git a/content/renderer/pepper/pepper_media_stream_track_host_base.cc b/content/renderer/pepper/pepper_media_stream_track_host_base.cc

index f1b4e4b14ab2b7a5f5b24a37a1a8ce342fe72dec..aadc7abf2276aaa65bd783bc7dcda9c812f968b7 100644

--- a/content/renderer/pepper/pepper_media_stream_track_host_base.cc

+++ b/content/renderer/pepper/pepper_media_stream_track_host_base.cc

@@ -39,6 +39,8 @@ bool PepperMediaStreamTrackHostBase::InitFrames(int32_t number_of_frames,

// Make each frame 4 byte aligned.

frame_size = (frame_size + 3) & ~0x3;

+ // TODO(penghuang): |HostAllocateSharedMemoryBuffer| uses sync IPC. We should

+ // avoid it.

int32_t size = number_of_frames * frame_size;

content::RenderThread* render_thread = content::RenderThread::Get();

scoped_ptr<base::SharedMemory> shm(