Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Unified Diff: chrome/browser/profiles/profile_window.cc

Issue 1407753002: Clean up terminology used in about_flags. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove unneccessary divs. Created 5 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/about_flags_unittest.cc ('k') | chrome/browser/ui/webui/flags_ui.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/profiles/profile_window.cc
diff --git a/chrome/browser/profiles/profile_window.cc b/chrome/browser/profiles/profile_window.cc
index a5ffc711e18546f1cc269bd872b35d248184edf3..4d01ff6dd3833fe83aa665013b9fbecbf163d9ba 100644
--- a/chrome/browser/profiles/profile_window.cc
+++ b/chrome/browser/profiles/profile_window.cc
@@ -468,12 +468,12 @@ void EnableNewProfileManagementPreview(Profile* profile) {
#else
// TODO(rogerta): instead of setting experiment flags and command line
// args, we should set a profile preference.
- const about_flags::Experiment experiment = {
+ const about_flags::FeatureEntry entry = {
kNewProfileManagementExperimentInternalName,
0, // string id for title of experiment
0, // string id for description of experiment
0, // supported platforms
- about_flags::Experiment::ENABLE_DISABLE_VALUE,
+ about_flags::FeatureEntry::ENABLE_DISABLE_VALUE,
switches::kEnableNewProfileManagement,
"", // not used with ENABLE_DISABLE_VALUE type
switches::kDisableNewProfileManagement,
@@ -483,10 +483,8 @@ void EnableNewProfileManagementPreview(Profile* profile) {
};
flags_ui::PrefServiceFlagsStorage flags_storage(
g_browser_process->local_state());
- about_flags::SetExperimentEnabled(
- &flags_storage,
- experiment.NameForChoice(1),
- true);
+ about_flags::SetFeatureEntryEnabled(&flags_storage, entry.NameForChoice(1),
+ true);
switches::EnableNewProfileManagementForTesting(
base::CommandLine::ForCurrentProcess());
@@ -500,7 +498,7 @@ void EnableNewProfileManagementPreview(Profile* profile) {
void DisableNewProfileManagementPreview(Profile* profile) {
flags_ui::PrefServiceFlagsStorage flags_storage(
g_browser_process->local_state());
- about_flags::SetExperimentEnabled(
+ about_flags::SetFeatureEntryEnabled(
&flags_storage,
kNewProfileManagementExperimentInternalName,
false);
« no previous file with comments | « chrome/browser/about_flags_unittest.cc ('k') | chrome/browser/ui/webui/flags_ui.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698