Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(67)

Issue 1407733002: Add --src-dir flag to landmines.py. (Closed)

Created:
5 years, 2 months ago by kjellander_chromium
Modified:
5 years, 2 months ago
Reviewers:
scottmg
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add --src-dir flag to landmines.py. This will make it possible to reuse the script in projects with different directory layouts than Chromium, since the current version assumes the root is two levels above the script location. BUG=webrtc:5077 TESTED=Manually running the script and running runhooks. Committed: https://crrev.com/20b291561ce84495d9af94b5cc7f0cb9765d128c Cr-Commit-Position: refs/heads/master@{#354083}

Patch Set 1 #

Patch Set 2 : Remove whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -17 lines) Patch
M build/landmines.py View 1 6 chunks +28 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
kjellander_chromium
This will make it possible for WebRTC to reuse the landmines.py script, thus avoiding to ...
5 years, 2 months ago (2015-10-14 14:41:50 UTC) #2
scottmg
lgtm
5 years, 2 months ago (2015-10-14 17:08:27 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407733002/20001
5 years, 2 months ago (2015-10-14 18:49:10 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 2 months ago (2015-10-14 19:00:12 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1407733002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1407733002/20001
5 years, 2 months ago (2015-10-14 19:23:37 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 2 months ago (2015-10-14 19:28:18 UTC) #10
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/20b291561ce84495d9af94b5cc7f0cb9765d128c Cr-Commit-Position: refs/heads/master@{#354083}
5 years, 2 months ago (2015-10-14 19:30:11 UTC) #11
Michael Achenbach
5 years, 2 months ago (2015-10-15 07:13:29 UTC) #12
Message was sent while issue was closed.
Awesome, now that this is reusable, we should move it into the buildtools repo
for easier sharing with other projects.

Powered by Google App Engine
This is Rietveld 408576698